refactor: remove the googlesql module#2482
Merged
chelsea-lin merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_googlesql
branch
2 times, most recently
from
f3d2601 to
7d5566b
Compare
chelsea-lin
force-pushed
the
main_chelsealin_googlesql
branch
2 times, most recently
from
6d6a38e to
83c726f
Compare
|
📢 Migration Notice: 📢 This library is moving to the google-cloud-python monorepo soon. We kept this PR open due to recent activity. We would like to finalize this PR so it can be merged if it is critical. If we don't hear from the PR author, we will close this PR in the next few days. The PR can then be re-opened in the monorepo once the migration is complete and work can continue there. |
sycai
reviewed
Mar 2, 2026
| import google.cloud.bigquery.table | ||
|
|
||
| import bigframes.core.compile.googlesql as googlesql | ||
| import bigframes.core.compile.sqlglot.sqlglot_ir as sqlglot_ir |
Contributor
There was a problem hiding this comment.
nit: This import aliasing is unnecessary. Maybe we could just
from bigframes.core.compile.sqlglot import sqlglot_ir
83c726f to
12ab4ec
Compare
sycai
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 488047595🦕